[Bug 28791] New: pendingproc_cleanup_pending_messages_db has been disabled

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28791

           Summary: pendingproc_cleanup_pending_messages_db has been
                    disabled
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: logger
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: guillaume.desmottes at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


In order to fix bug #28787 I commented out
pendingproc_cleanup_pending_messages_db.
According to the doc of this fucntion, that's just an optionnal optimisation so
that's not the end of the world but we should fix it properly.

Few things seem wrong to me in it:

- SQL procedures can take a while. Is there any reason to block returning from
ObserveChannels on this? If not, this function should be removed from the
channel preparing chain.

- tpl_channel_text_clean_up_stale_tokens() iterates on the tokens and call
_tpl_log_store_sqlite_set_acknowledgment() for each token. So a new SQL command
is executed for each token! I'm not a SQL guru but I'm sure we could create a
single command operating on all the tokens.

- According to pendingproc_cleanup_pending_messages_db's DEBUG message, this
function is supposed to remove entries from the DB. But
_tpl_log_store_sqlite_set_acknowledgment() does a SQL UPDATE so nothing is
actually removed. Is that expected?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.