[Bug 27835] Avoid being notified about Connection features nobody cares about

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27835

--- Comment #8 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-29 04:40:57 PDT ---
(In reply to comment #3)
> In Bug #27948, if you try to Remove an interest you didn't have in the first
> place, no error is raised. I don't think this is a problem, because in
> practice, what are you going to do about it? - actually, I think Add and Remove
> should both be called with no reply (fire-and-forget).

I've removed the error from the spec and defined the method as "never fails".

> I now wonder whether the Add D-Bus method should become singular (rationale: in
> practice, nobody's going to subscribe to multiple things at once).
> 
> The Remove method should probably stay plural, so a hypothetical future
> TpConnection can release all of its subscriptions at once.

Remove needs to stay plural, so I've left them both plural for symmetry.

(In reply to comment #5)
> We should perhaps allow the strings to be either interfaces or tokens, rather
> than restricting to only interfaces as we currently do, to allow an interface
> to have more than one token.

Done.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.