[Bug 13350] ContactInfo interface

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=13350


Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
            Summary|ContactInfo: implement and  |ContactInfo interface
                   |undraft                     |
  Status Whiteboard|waiting for impl            |




--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-03-01 13:01:06 PST ---
(In reply to comment #4)
> The Contact_Info_Flag type should be called Contact_Info_Flags, with
> Contact_Info_Flag as its member prefix.

Done in smcv/contact-info; this required some slight alterations to wording

> Contact_Info_Field_Flag_Parameters_Mandatory is a cumbersome name, and if
> you're not paying attention, the mention of "mandatory" makes it look as though
> the *field* is mandatory. Perhaps we could rename it to
> Contact_Info_Field_Flag_Params_Exact?

Done in smcv/contact-info

(In reply to comment #3)
> Looks good, except: [...]

Fixed in smcv/contact-info

> Marco has requested that the network-traffic-provoking part of GetContactInfo
> is replaced by something like a fire-and-forget RefreshContactInfo(au:
> Contacts) -> void, which polls all of those contacts' info and emits
> ContactInfoChanged signals. This seems easy to do.

Done in smcv/contact-info, but I haven't implemented this in Gabble yet (I'd
like to get the initial implementation merged first)

> * SupportedFields and ContactInfoFlags should have the same semantics as
> SupportedAvatarMIMETypes and friends

Done in smcv/contact-info

> * For interop, it would be nice to have a more elaborate example of ORG:
> perhaps the Wee Ninja should have "ORG:Collabora, Ltd.;Management
> Division;Human Resources\; Company Policy Enforcement" or something, to
> demonstrate nested org.units)

Done in smcv/contact-info

> * Similarly, we should include LABEL (preformatted address) in the list of
> well-known vCard fields, and give the Wee Ninja's address label

Done in smcv/contact-info


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.