[Bug 26951] New:=?UTF-8?Q?=20Expose=20=E2=80=9CMUC=20full=E2=80=9D=20as=20Busy=20on=20the=20group=20interface?=.

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=26951

           Summary: Expose “MUC full” as Busy on the group interface.
           Product: Telepathy
           Version: 0.8
          Platform: Other
               URL: http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-
                    wjt.git;a=commitdiff;h=refs/heads/busy-kind-of-means-
                    full
        OS/Version: All
            Status: NEW
          Keywords: patch
          Severity: normal
          Priority: medium
         Component: gabble
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: will.thompson at collabora.co.uk


When you try to join a room uninvited, and it's full, the request correctly
fails with the Channel.Full error.

However, if you're invited to a room, and you try to accept the invitation and
the room's full, you get removed from the group interface for reason None and
then the channel spontaneously closes. In TpChannel terms, the invalidation
error is TP_ERROR_REMOVED_FROM_GROUP, TP_CHANNEL_GROUP_CHANGE_REASON_NONE,
which is unhelpful.

My patch in busy-kind-of-means-full exposes this as Group_Change_Reason_Busy,
which seems like a reasonable approximation. A better fix might be:

• Make Gabble include the Channel.Full error (and indeed other errors like
Invite_Only) in the MembersChangedDetailed details;
• Make TpChannel smarter about what it saves from the
MembersChanged[Detailed]
signal so that it can synthesise better error messages.

But using a slightly more useful group change reason doesn't hurt anyway.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.