[Bug 27014] Implement conference interface

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=27014





--- Comment #6 from Jonny Lamb <jonny.lamb at collabora.co.uk>  2010-03-11 10:05:56 PST ---
(In reply to comment #4)
> This only a preliminary review, I didn't test it, because I would rather want
> to wait you divide the two use case in two separate classes. The TextChannel
> class as it is in this patch is barely understandable and maintainable.

jaksdhkjhadfjkadshakjsdha

I'll do this later. For now:

>   * Need to be adapted to use NoneHandle

Done. 

>   * Please check version against (0,15,16,1) that's the actual dev version
> numbers

Telepathy projects have a policy of not depending on unreleased versions of
libraries. I don't expect to merge my conference branch to butterfly until a
new tp-python release is cut. So, no.

>   * ButterflyChannelManager: shouldn't that actually be different classes with
> each of the Initial* as a mandatory parameter?

Please say "channel class" when you mean that. I got so confused because I
thought you were talking about python classes. Okay, yeah I've fixed that now.

>   * AddMembers is implemented but the group flag is 0, which don't allow the
> client to call it

Good catch. Fixed.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.