[Bug 27271] New: API review: TplLogEntry, TplLogEntryText

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=27271

           Summary: API review: TplLogEntry, TplLogEntryText
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: logger
        AssignedTo: simon.mcvittie at collabora.co.uk
        ReportedBy: simon.mcvittie at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org
                CC: cosimo.alfarano at collabora.co.uk


Placeholder bug for C API review.

In Bug #27178, Cosimo writes:

> log-entry.c/log-entry-text.c
> 
> the naming follows the ChannelType.
> 
> There are several methods duplicated, my intention is to drop most of them and
> keep only
> tpl_log_entry_<method> for what is implemented in TplLogEntry and
> tpl_log_entry_text_<method> for what is implemented in TplLogEntryText
> 
> dropping things similar to:
> 
> const gchar* (*get_log_id) (TplLogEntry *self);
> 
> in TplLogEntryClass and the related
> 
> const gchar *tpl_log_entry_text_get_log_id (TplLogEntryText *self);
> 
> which create only confusion and keeping only
> 
> const gchar* tpl_log_entry_get_log_id (TplLogEntry *self);
> 
> Unless in tp-glib is done differently.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.