[Bug 25493] GTalk-compatible file transfers are not implemented

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=25493


Youness Alaoui <youness.alaoui at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |youness.alaoui at collabora.co.
                   |                            |uk




--- Comment #18 from Youness Alaoui <youness.alaoui at collabora.co.uk>  2010-03-24 18:20:22 PST ---
(In reply to comment #14)
> So, after a long discussion over IRC, here is a summary of the tasks that I
> need to do to fix the various issues discussed previously :
> - renaming GtalkFTManager into GTalkFileCollection
DONE

> - rename JingleChannel (and jingle channel references) into ShareChannel
DONE

> - move the manifest parsing into the GabbleFileTransferChannelManager and
> remove the call to 'gabble_file_transfer_channel_new' from the
> GTalkFileCollection
DONE

> - rename gabble_file_transfer_channel_set_gtalk_ft_state into
> gabble_file_transfer_channel_gtalk_ft_state_changed to make it clear it's a
> 'signal-like' API.
DONE

> - add comments explaining the design and layering violation, as well as the
> protocol and object associations
DONE (see
http://git.collabora.co.uk/?p=user/kakaroto/telepathy-gabble.git;a=commitdiff;h=a946d89a524d8dcb2b80db353132ffdfe1cb795c
)
sjoerd said it made sense..

> - remove GabbleChannel and use the channel's 'ACCEPTED' state for 'usable' and
> use a GHashTable for the 'readable' fields of GabbleChannel.
DONE

> 
> 
> - Do you still want me to cherry-pick the bytestrean/bytestream typo fix ?
DONE, make check worked (apart from the mail-notification test..) and
considered insta-reviewed, so I've merged it into master

> - You still want me to remove/refactor the 'media-type' property ?
next on my TODO

> - strict aliasing issues with g_has_table_iter_next?
DONE, have a look at :
http://git.collabora.co.uk/?p=user/kakaroto/telepathy-gabble.git;a=commitdiff;h=131531e300923cdabbbb852cdbe2e5618a371f15

> - Is it fine to not use gabble_generate_id?
I'll use it and use something to remove non [a-zA-Z0-9] chars.

> - How about the hard-coding special treatment in GabbleJingleContent? Should I
> find a better solution to all that ?
Will fix it.

> - We forgot to discuss on how to handle SI vs. jingle-share decision in gabble.
I think 'if you have turn set up, use jingle, otherwise SI', because even with
libnice, in some cases it might fail. with SI, you always have some socks5
proxies, right? if not, then 'if no turn and no socks5 proxy, use jingle' I
guess.

> - other strict aliasing issue with content_new_channel_cb.
DONE, have a look at it :
http://git.collabora.co.uk/?p=user/kakaroto/telepathy-gabble.git;a=commitdiff;h=05d39c74f81e3a7e8944d02f93c6c622c5f8f2e9


I also reverted back the patch that removed the check for the google dialect in
the jingle-transport-google.

So for now we have :
- Remove the MEDIA_TYPE for jingle-share
- Remove special cases in jingle-content and add some new virtual methods for
jingle-share.
- use gabble_generate_id.
- wrote decision algo on whether to use jingle or SI (right now, it uses jingle
only if SI is not supported (gtalk)).
- fix my TODO tags

If you think I forgot something, let me know!
Until I'm done and you go through your second pass review, you can already
start reviewing my latest individual fixes from here : 
http://git.collabora.co.uk/?p=user/kakaroto/telepathy-gabble.git;a=shortlog;h=refs/heads/review-fixes

p.s.: is it just me or has it become impossible to find something in this
thread? :p


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.