[Bug 25493] GTalk-compatible file transfers are not implemented

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=25493





--- Comment #21 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-03-25 08:28:38 PST ---
(In reply to comment #19)
> except that I'd like all the instances of gtalk_fc, GTALK_FC and (if any)
> GTalkFc to be gtalk_file_collection, etc.

To clarify that: I'd prefer properties and other public API to have the full
name, and I'd prefer instance members (self->priv->gtalk_file_collection) to
have the full name to be consistent with the properties they implement, but
local variables can be gtalk_fc or fc or collection or something.

The review-fixes branch looks good up to
http://git.collabora.co.uk/?p=user/kakaroto/telepathy-gabble.git;a=commit;h=131531e300923
(your last commit at the time of writing), apart from the things I mentioned.
The documentation you added really helps - thanks!


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.