[Bug 30649] Give warning for unknown interface elements

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30649

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|review+                     |review-, trivia

--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2010-10-06 05:46:02 PDT ---
PEP 8 says:

> The preferred place to break around a binary operator is
> *after* the operator, not before it.

So this part of your comprehension is bad and wrong:

+            if isinstance(x, xml.dom.minidom.Element)
+            and (x.namespaceURI, x.localName) not in expected

It should be:

+            if isinstance(x, xml.dom.minidom.Element) and
+               (x.namespaceURI, x.localName) not in expected

(lining up the second condition with the first one).

Fair point about the second suggestion.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.