[Bug 26590] GetFrequentContacts

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=26590

--- Comment #8 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-10-07 05:54:58 PDT ---
Does this code assume that we are using the sqlite store to store messages?
Afaik, we are still using the XML one atm.

Including chatrooms in the result of a function called Get_Recent_*Contacts*
seems bong to me. What's the use case for this?
Same for GetFrequentContacts

      /* we assume that the AM is ready */
Ideally,  TplDBusService should have a priv->account_mgr and not be registered
until it has been prepared so we don't have to check if features are prepared
and just assert they are.

_tpl_get_tp_account()
why not use tp_account_manager_ensure_account() so we reuse existing TpAccount?

+  if (priv->sqlite_store)
+    {
+      g_object_unref (priv->sqlite_store);
+      priv->sqlite_store = NULL;
+    }
tp_clear_object() ftw!

You could make use of tp_value_array_unpack()

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.