[Bug 26590] GetFrequentContacts

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=26590

--- Comment #9 from Danielle Madeley <danielle.madeley at collabora.co.uk> 2010-10-07 06:00:11 PDT ---
(In reply to comment #8)
> Does this code assume that we are using the sqlite store to store messages?
> Afaik, we are still using the XML one atm.

No, log-store-sqlite is keeping a cache for us. This is actually what I
originally wrote it for, and the code to do it got merged some time ago.

> Including chatrooms in the result of a function called Get_Recent_*Contacts*
> seems bong to me. What's the use case for this?
> Same for GetFrequentContacts

Suggestions for new names?

>       /* we assume that the AM is ready */
> Ideally,  TplDBusService should have a priv->account_mgr and not be registered
> until it has been prepared so we don't have to check if features are prepared
> and just assert they are.

Should I take out the check then?

> _tpl_get_tp_account()
> why not use tp_account_manager_ensure_account() so we reuse existing TpAccount?

If someone passes a made-up account path it will create that object on the bus?
I want it to error instead.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.