[Bug 26590] GetFrequentContacts

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=26590

--- Comment #13 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-10-11 01:46:14 PDT ---
(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #9)
> > > > Including chatrooms in the result of a function called Get_Recent_*Contacts*
> > > > seems bong to me. What's the use case for this?
> > > > Same for GetFrequentContacts
> > > 
> > > Suggestions for new names?
> > 
> > Do we really need chat rooms tbh? If we do I'd be tempted we should either have
> > a GetFrequentChatrooms() or express the API in term of TpHandleType.
> 
> I don't see why you wouldn't include them in the same API. TpHandleTypes can't
> be used as a bitwise mask.

I don't like this API. Get{Frequent,Recent}*Contacts* should only return
contacts or be renamed. Furthermore, the semantic of being frequent/recent is
not clear. Does it involve only chat or also call (once we'll suport them)?

(In reply to comment #12)
> > You could make use of tp_value_array_unpack()
> 
> Where? The only new calls to g_value_array_get_nth() are specifically
> retrieving the nth value of multiple structures.

You're right, sorry.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.