[Bug 27175] Make TpMessage usable in clients

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27175

--- Comment #2 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-10-13 07:56:18 PDT ---
(In reply to comment #1)
> Things needing fixing:
> 
> - consider making it a GObject, with tp_message_destroy a deprecated alias for
> g_object_unref?

Makes sense.

> - make client-side received-message objects read-only? (we still need the set
> methods to work client-side while sending a message, though)

Should we use the same object or a new one sharing a common sub-class?

> - make it use TpVariantMap internally (Bug #30423) and use the dbus-glib escape
> hatch to convert to/from dbus-glib GValues when necessary?

I guess we need both variants, right?

> - add a tp_message_copy?

Not sure that's needed, we can just ref the object.

> - handle refcounting works differently in the CM and in a client

Yeah, which make me think it could be cleaner to have 2 objects.

> - the client-side version probably wants a small amount of TpContact
> interaction?

Probably yeah. 

> - also deal with the case of a serialized/deserialized message (use GVariant),
> in which handles are no longer meaningful, but string IDs are still useful?

Humm, I'm not sure to understand. Can you ellaborate?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.