[Bug 30386] Regression: StreamedMediaChannel::streamAdded is not emitted when one requests a new stream using a StreamedMedia channel type

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Oct 13 17:10:52 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=30386

Olli Salli <ollisal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+

--- Comment #3 from Olli Salli <ollisal at gmail.com> 2010-10-13 08:10:51 PDT ---
Review:

Good catch about the RequestDirection bug. However, currently there's always a
group self contact (can be faked from the connection self contact) whenever a
Channel is ready - so instead of conditionalizing on whether there is a group
self contact, just make requestDirection early-fail (PendingFailure) if the
Channel on which it's called on doesn't have Channel::FeatureCore ready. We
need that to be ready to know our real groupSelfHandle, if any, anyway.

Added tests seem OK - through due to the complexity/clutter of the API, it's a
bit hard to tell for sure :(

So OK to merge with that requestDirection being-ready change.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list