[Bug 31001] New: channel client factory: add API for TpChannel preparation

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31001

           Summary: channel client factory: add API for TpChannel
                    preparation
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: medium
         Component: tp-glib
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: guillaume.desmottes at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


On bug #29973 we considered 2 options regarding preparations of extra features:

A) Add a prepare async API on TpClientChannelFactoryInterface doing the
preparation of a TpChannel

b) Add API to get a list of features to be prepared and let the user
(TpBaseClient basically) doing the preparation.

The consensus seems to go for B) as TpBaseClient already has code to prepare
the channels.
If that's ok I'll do the following changes:

-  Add GQuark *features tp_client_channel_factory_get_features
(TpClientChannelFactoryInterface *self, TpChannel *self) implemented using a
virtual function returning CORE as default implementation.
Or maybe we should return a more flexible structur to make it easier to merge
it with TpBaseClient's features?

- Modify TpBaseClient to prepare the union of its features and the ones
returned by _get_features(). I guess that's fine if we ask to prepare twice the
same feature.

- Implement _get_features () inTpAutomaticProxyFactory  by returning CORE +
TP_CHANNEL_FEATURE_GROUP if the channel implements Group.

- I'm not sure if we want to add API on TpClientChannelFactoryInterface to add
features? It seems weird to add features on a factory which already created
channel. And clients can still add feature on TpBaseClient or create their own
factory if needed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.