[Bug 14003] Connection: interface to ask for credentials (SASL auth channels)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=14003

--- Comment #25 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-10-21 09:44:26 PDT ---
(In reply to comment #24)
> I'm really not sure whether AuthenticationInformation belongs on the
> ServerAuthentication channel type: none of the keys you've defined seem useful
> or indeed possible outside (pseudo-)SASL.

The current draft shuffles them onto SASLAuthentication, but also retains
AuthenticationInformation for the moment.

I separated AuthorizationIdentity (the former username) and DefaultRealm (the
former realm) into their own properties, and put the former session-id in an
ExtraContext a{sv} as "jabber-stream-id". I think it's right that
AuthorizationIdentity is separate, but I'm undecided about DefaultRealm.

> > > Are the username and realm in Auth_Details the same as SASL RFC 4422's
> > > "authorization identity strings" or are they intended as something to put in
> > > the UI presented to the user or what?
> 
> I haven't expanded on these yet.

Now done.

> > Gabble doesn't have the complete set, in particular it can't restart a sasl
> > try.
> 
> Hmm, yeah, about that... it raises NotAvailable, which I've used to mean
> "you're in the wrong state". We should have a separate code for "we failed and
> the connection is no more". I wonder whether that code should in fact be that
> the connection just disconnects.

Thinking about it, I think it'd be OK to say NotAvailable, as long as there's a
boolean property CanTryAgain, which I've added.

XMPP would usually have CanTryAgain = TRUE, but Wocky doesn't support it,
therefore Gabble doesn't either (if I'm reading the implementation correctly).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.