[Bug 28413] Gabble DTMF

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28413

--- Comment #9 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2010-10-22 04:16:56 PDT ---
(In reply to comment #7)
> I now also have a subset of that branch,
> <http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git;a=shortlog;h=refs/heads/dtmf-from-the-past>,
> which doesn't implement MultipleTones. We could use that branch to get basic
> DTMF support merged without deciding on MultipleTones' exact semantics.

Your branch looks good. Just two things:

 * The spec says InvalidArgument is only used for an invalid stream ID
   but now that's deprecated. However, surely it can be used for a bad
   event type?

 * When the channel is closed and events are currently being sent then
   StoppedTones(False) should be fired.

> That subset doesn't have a regression test, but I could backport the one from
> smcv/dtmf (with the MultipleTones-related bits deleted) if required.

I haven't looked at your dtmf branch yet, but yeah a test would be nice.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.