[Bug 31031] Add (optional) support for Nokia's heartbeat service

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31031

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|review-                     |

--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk> 2010-10-25 04:35:23 PDT ---
(In reply to comment #2)
> Nothing major: 1 trivium and one question:
> 
> Trivium:
> 
> where DEBUG output is to tell us there's been a wakeup or a ping 
> has gone out or the ping timeout has changed, it might be worth 
> logging the (high-ish res)time at which said event occurred

Added.

> Question:
> 
> self->next_wakeup.tv_sec += (max_interval - self->max_interval);
> can go -ve, I _think_ this means we just wake up straightaway,
> I assume that's Ok?

Yeah, that was the intention. I've added a clarifying comment.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.