[Bug 27175] Make TpMessage usable in clients

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Oct 25 13:47:19 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=27175

--- Comment #8 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-10-25 04:47:18 PDT ---
So I created TpClientMessage and started to use it:
http://git.collabora.co.uk/?p=user/cassidy/telepathy-glib;a=shortlog;h=refs/heads/text-channel-29531

Could you take a quick look and check if I'm going to right direction?

So far I didn't had the need to have this object (TpMessage is enough) but I'd
say having a new class is cleaner and more future proof.

I didn't make the initial_parts / size_hint distinction in
tp_message_client_new() as I'm not sure what it really buys us.

Also, I guess we could have a tp_message_client_new_text
(TpChannelTextMessageType type, const ghcar *text); for the most common case?

I'm also not sure how we should deal with delivery reporting/failure. See the
FIXME in send_message_cb

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list