[Bug 30088] TpBaseProtocol: add Presence

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30088

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://git.collabora.co.uk/ |http://git.collabora.co.uk/
                   |?p=user/vivek/telepathy-gli |?p=user/smcv/telepathy-glib
                   |b;a=shortlog;h=refs/heads/o |-smcv.git;a=shortlog;h=refs
                   |fdt-protocol-interface-pres |/heads/proto-presence
                   |ences                       |
  Status Whiteboard|r+, but merge/rebase needed |
           Keywords|                            |patch
         AssignedTo|telepathy-bugs at lists.freede |simon.mcvittie at collabora.co
                   |sktop.org                   |.uk

--- Comment #9 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-10-26 08:34:33 PDT ---
Branch stolen, updated to master and documented. (Please make sure check passes
with gtk-doc enabled in future.)

Things I'm suspicious about here:

This makes TpBaseProtocol's API depend on TpPresenceStatusSpec, which is a bit
crufty - it has an array of optional arguments from which we use only
"message".

I wonder whether to turn one of the spare gpointer fields into a boolean
indicating whether there's a message, which would make it less "this is a relic
of a previous age, via TpPresenceMixin" and more SimplePresence'y.

Alternatively, we could introduce

TpNamedStatusSpec = struct {
    const gchar *name;
    TpConnectionPresenceType;
    gboolean settable;
    gboolean message;
    gpointer _padding[n];
}

and use that in both TpBaseProtocol and TpPresenceMixin?

Not a blocker for telepathy-glib 0.13.3, I don't think.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.