[Bug 28726] Support Google's Shared Status extension

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28726

--- Comment #12 from Eitan Isaacson <eitan.isaacson at collabora.co.uk> 2010-10-27 08:10:28 PDT ---
(In reply to comment #9)
> Did you mean to add some text with your reply? :)
> 

Yes, I did. All the revs above don't exist anymore after a recent rebase.

> > Assert that stanza has query element before using.
> 
> This is a stanza that the server just sent us. If the server messes up, we
> shouldn't crash. The code should treat the <query/> element being missing as
> equivalent to getting an error back.

Yes, this was stupid. 6fca8f3

> 
> Also I noticed that get_shared_status_cb() contains:
> 
>  938       DEBUG ("Error getting privacy lists: %s", error->message);
> 
> which is not quite right.

bf32c6c

> 
> You didn't address my question about why get_bare_self_jid() was moved to
> util.h, rather than living in a connection-related header.

I rebased the branch on a patch that puts this in conn-util.c. 9911a07

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.