[Bug 31198] Windows portability patches for telepathy-glib

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Oct 29 14:25:28 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=31198

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-10-29 05:25:28 PDT ---
Review of attachment 39855:
 --> (https://bugs.freedesktop.org/review?bug=31198&attachment=39855)

The previous implementation dynamically allocated more stack, which is meant to
work, but I can see that it's not necessarily the most portable thing to do.

We prefer to use g_malloc() and g_free() instead of malloc() and free().

I'd be inclined to remove the artificial block now that we're not using it for
its side-effect of letting us have more stack. I'll prepare an alternative
patch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list