[Bug 31200] Windows portability patches for telepathy-qt4

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Oct 29 14:44:12 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=31200

--- Comment #6 from Andre Moreira Magalhaes <andrunko at gmail.com> 2010-10-29 05:44:11 PDT ---
(In reply to comment #5)
> Review of attachment 39859 [details]:
> 
> ::: TelepathyQt4/capabilities-base.cpp
> @@ -161,3 @@
>      uint targetHandleType;
>      foreach (const RequestableChannelClass &cls, mPriv->classes) {
> -        if (!cls.fixedProperties.size() == 2) {
> 
> This looks like a real bug, in fact; the precedence isn't what the author of
> this code expected.
> 
> The fix should be "if (blahblah.size() != 2)", though :-)
Ooops :D. I fixed this in my rcc-high-level branch that should be merged any
time soon.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list