[Bug 29409] StatefulDBusProxy should use QDBusServiceWatcher, if available

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29409

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
  Status Whiteboard|                            |review-, minor changes
         AssignedTo|telepathy-bugs at lists.freede |andrunko at gmail.com
                   |sktop.org                   |

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-09-01 02:55:18 PDT ---
Major: please preserve the code order so you connect to the signal before
calling the method, to not race.

Minor: in configure.ac, I'd prefer to add an AC_MSG_CHECKING...AC_MSG_RESULT
pair, so we get:

    checking for QDBusServiceWatcher... yes

in buildbot logs. You can either check for it like you did, or via a pkg-config
check for QtDBus >= 4.6.n, whichever's easier for you.

If you check for the functionality rather than the version, please also add a
comment saying "delete this check when we depend on Qt >= 4.6.0" (replace
version as appropriate).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.