[Bug 28866] Allow channel requesters to associate metadata with requests for the benefit of other clients

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28866

--- Comment #10 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-09-01 08:23:03 PDT ---
(In reply to comment #9)
> I fixed this one (not sure if that's the best way, this code looks like a bit
> like a can of worms to me tbh :\ )

This code *is* a can of worms :-( See smcv/wip-req-export, in which I tried to
split McdChannel into the bits that are really a channel and the bits that are
a channel request, and have the latter be exported as the ChannelRequest; in
particular, the top commit, which is called "WiP: doesn't work" and is
something like my 5th attempt at it.

Your code changes look good, except for the last commit where I need to read
the code a bit more to work out wtf is going on. I suspect that what you did is
necessary and correct, even though it makes little sense.

Would you mind if I pick up this branch and make it use an in-tree extension
instead of the patched telepathy-glib you're presumably using, so we can merge
it before undrafting the spec, and continue to refactor?

> (In reply to comment #6)
> > > mcd-channel: store the channel request object in satisf...
> > 
> > I haven't reviewed this, because I think merging and using smcv/requests is
> > probably a better way forward.
> 
> How does this branch help? This commit hasn't changed after the rebase.

It turns out smcv/requests isn't actually sufficient; for the simplification,
you'd need some of the commits from smcv/wip-req-export (moving all the
ChannelRequest properties to McdRequest and adding
_mcd_request_dup_immutable_properties()). With those added, my idea was to have
a GList of McdRequest, rather than a GList of McdChannel. I'm not sure whether
that will actually be enough... I hope so.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.