[Bug 29943] Make TpDebugSender's g_log handler thread safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29943

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-09-01 10:55:14 PDT ---
Review of attachment 38363:
 --> (https://bugs.freedesktop.org/review?bug=29943&attachment=38363)

::: telepathy-glib/debug-sender.c
@@ +401,3 @@
+    goto ignore_message;
+
+  if (g_queue_get_length (debug_sender->priv->messages) >=
DEBUG_MESSAGE_LIMIT)

This stuff needs factoring out of tp_debug_sender_add_message() into a common
helper, instead of being duplicated.

@@ +494,3 @@
+  /* This could be called from any thread, but since Telepathy-GLib is not
+   * in any way thread safe, we must send it to the main loop to be
+   * processedx

"processed"

(FWIW, it's mostly dbus-glib that's not thread-safe)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.