[Bug 20034] Avatar cache reference implementation

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=20034

--- Comment #4 from Andre Moreira Magalhaes <andrunko at gmail.com> 2010-09-03 05:06:06 PDT ---
So here follows the review, already talked to Xavier about them, just in case
others want to check also and have anything else to discuss:

- Add a structure Tp::AvatarInfo and use it for avatar getter (AvatrarInfo
avatarInfo() const) and signal (void avatarInfoChanged(const Tp::AvatarInfo
&info). That is good so once we add Tp::Contact Qt property support we can have
property notification for avatar info changes
- Check coding style:
   - Always use {} even for one line statements
   - type& should be type &
   - See HACKING for more info
- Call RequestAvatars in a batch instead of doing it 1 contact by 1 (known
issue)
- Tests (known issue)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.