[Bug 26866] add support for requesting handles for a vCard field or URI

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=26866

--- Comment #52 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-09-07 03:07:40 PDT ---
(In reply to comment #51)
> with additional amendments

Please give reviewers a chance to review all non-trivial amendments before
pushing to master. Typo and build-system fixes are sometimes considered
trivial; clarifications and normative changes are never trivial.

(This also means that rebasing just before pushing is unhelpful, because
reviewers can't tell what has changed.)

> +        following lines in it's <tt>.manager</tt> file.</p>

Still typo'd

> +          <dt><code>x-icq</code></dt>
> +          <dd>The X-ICQ vCard field. Used for ICQ UINs.</dd>

Duplicated

> +          <dt><code>x-skype</code></dt>
> +          <dd>The X-SKYPE vCard field. Used for Skype user names or
> +          telephone numbers.</dd>
> +          <dt><code>x-skype-username</code></dt>
> +          <dd>The X-SKYPE-USERNAME vCard field. Used for Skype user names.</dd>

I think we should choose one of these (I would suggest X-SKYPE unless there are
reasons to prefer X-SKYPE-USERNAME) and say that for the purposes of Telepathy,
it is the preferred form.

> +          <dt><code>msnm</code></dt>
> +          <dd>The authority part of this URI is ignored. Instead, the
> +            <code>contact</code> query key is used.
> +            For example: <code>msnim:chat?contact=julien</code>.</dd>

Typo: s/msnm/msnim/

This is not a hierarchical URI, so it doesn't have an authority part: I'd say
"verb part".

The thing I wanted you to say about msnim (and the other always-verb-like
schemes) is something like "For the purposes of _Protocol.I.Addressing_,
_Conn.I.Addressing_ and _Chan.I.Addressing_, the verb part is ignored, and
SHOULD be "add"; the contact field in the query string is used to identify the
contact."

Same comments about aim and ymsgr.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.