[Bug 28420] Need accessor for all Channel properties

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28420

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-09-08 03:27:55 PDT ---
> -  tp_debug_set_flags ("all");
> +  //tp_debug_set_flags ("all");

If you want to make this change (which would be entirely reasonable IMO), just
delete the line.

(One day I'd like a mechanism to capture each debug log to a file, and cat them
for each failed test; this is not that day, unless you're feeling tremendously
enthusiastic.)

> +   * %TRUE if the channel has been requested.

I think this deserves better documentation: in practice, nobody notices that
Requested is how you detect an "incoming"/"outgoing" channel. Perhaps something
like this:

    %TRUE if this channel was created in response to a local request, such
    as a call to tp_account_channel_request_create_channel_async(). %FALSE
    if this channel was initiated by a remote contact
    (the #TpChannel:initiator-handle), or if it appeared as a side-effect
    of some other action.

    For instance, this is %FALSE on incoming calls and file transfers,
    remotely-initiated 1-1 text conversations, and invitations to chatrooms,
    and %TRUE on outgoing calls and file transfers, locally-initiated 1-1
    text conversations, and chatrooms joined by local user action.

> +   * The #TpHandle of the initiator of this channel.

I think it's worth expanding on this too:

    The %TP_HANDLE_TYPE_CONTACT #TpHandle of the initiator of this
    channel, or 0 if there is no particular initiator.

    If the channel was initiated by a remote contact, this handle represents
    that contact, and #TpChannel:requested will be %FALSE. For instance,
    for an incoming call this property indicates the caller, and for a
    chatroom invitation this property indicates who sent the invitation.

    If the channel was requested by the local user, #TpChannel:requested
    will be %TRUE, and this property may be the #TpChannel:group-self-handle
    or #TpConnection:self-handle.

    If the channel appeared for some other reason (for instance as a
    side-effect of connecting to the server), this property may be 0.

> +   * The identifier of the initiator of this channel.

    If #TpChannel:initiator-handle is 0, this will always be "".
    Otherwise, this will be the #TpContact:identifier of the contact
    with that handle.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.