[Bug 28200] TpBaseContactList

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28200

--- Comment #49 from David Laban <david.laban at collabora.co.uk> 2010-09-08 11:55:46 PDT ---
(In reply to comment #47)
> ... and another which ports to TpBaseChannel. 47 insertions(+), 292
> deletions(-) :-)
> 
> (It would have been an even better diffstat, but contact list channels are
> weird and need to be able to raise errors from Close().)

This comment confused me until I saw the one that you removed further down the
file.
+/* We don't use this: #TpBaseChannelClass.close doesn't allow us to fail to
+ * close, which is a quirk of the old ContactList design. */

-  /* close is implemented in subclasses, so don't IMPLEMENT (close); */

How about:

/* We don't use this: #TpBaseChannelClass.close doesn't allow us to fail to
 * close, which is a quirk of the old ContactList design, so subclasses
 * IMPLEMENT (close) manually. */

[/pedantry]

But yeah: looks good. Ship it.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.