[Bug 29981] Support power saving interface

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29981

--- Comment #5 from Will Thompson <will.thompson at collabora.co.uk> 2010-09-09 03:08:55 PDT ---
(In reply to comment #3)
> Ok, now it is ready for review!

I'll review it later; here are some drive-by comments having not read the
branch.

> (In reply to comment #1)
> > -  /* We can only cork presence updates on Google Talk. Of course, the Google
> > -   * Talk server doesn't advertise support for google:queue. So let's use the
> > -   * roster again... */
> > -  if (!(conn->features & GABBLE_CONNECTION_FEATURES_GOOGLE_ROSTER))
> > -    return;
> > 
> > This check appears to have been lost, so we're sending commands to the server
> > without checking if it supports them. What we should do instead is not include
> > Connection.Interface.PowerSave in Connection.Interfaces if we're not on a
> > Google connection (so that MC knows not to bother telling Gabble the activity
> > status has changed), and probably also return an error from the method on
> > PowerSave() if someone decides to call it anyway.
> > 
> 
> I am not sure why that comment is there. "google:queue" does not get advertised
> in the connection disco. So the only way to know is trial and error (ie.
> SetPowerSaving and catch NotAvailable exception).

I know google:queue is not advertised. That's why the quoted-as-deleted code
above says exactly that, and explains that it's using the presence
google:roster to indicate that we're on a Google server. This isn't strictly
right, but it does work.

I've pinged a contact at Google to see about them actually advertising
google:queue.

> > The test should check what happens if Gabble's still waiting for a reply to a
> > <queue/> request when it's disconnected. I think the contact search tests have
> > an example of how to do this: you pass some EventPatterns to a helper function
> > that deals with the disconnection; so here we should presumably expect the
> > Cancelled error or something.
> > 
> 
> This would not really be regarded as an error, so if the connection drops
> before we get an ack, we will reënable presence queuing the next time it
> connects.

Yes, but it might crash. Stuff crashing if it's waiting for an IQ reply when we
disconnect is incredibly common.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.