[Bug 29981] Support power saving interface

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29981

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review-, minor changes
         AssignedTo|will.thompson at collabora.co. |eitan.isaacson at collabora.co
                   |uk                          |.uk

--- Comment #6 from Will Thompson <will.thompson at collabora.co.uk> 2010-09-09 10:10:09 PDT ---
Aside from my/Simon's comments above, just trivia about the updated code.

In toggle_queueing_cb():

+  DEBUG (" ");
+

Surely better just to log something in both branches of:

+  if (error)

(which should be "if (error != NULL)", or actually "if (reply == NULL)". Ditto
later in the file: if you check the reply's NULL-ness, you don't need the extra
conditional as to whether to unref it).

Hmm also, if we've got a stanza in flight to enable queueing, we probably don't
want to send a second one redundantly... but then this gets complicated. What
happens if someone calls SetPowerSaving(True), SPS(False), SPS(True), all
before the server responds to the first one. Probably not worth it.

+    gboolean in_Active,

This is a misleading name for the argument. The code-genned examples shouldn't
include the in_, really. But in this case it not only looks ugly, but means the
opposite of what was intended!

I think the GabbleConnection should have a "power-saving" property... and then
we could implement the D-Bus property using
tp_dbus_properties_mixin_getter_gobject_properties(). Much less faffing around
with quarks.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.