[Bug 28915] MC does not save "old-ssl" flag

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Sep 13 22:54:52 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=28915

--- Comment #11 from Vivek Dasmohapatra <vivek at collabora.co.uk> 2010-09-13 13:54:52 PDT ---
Blockers should be dealt with.

wrt: Why are you NIHing g_key_file_set_boolean et al? I can see 
that the code structure is vaguely attractive, but...

Largely so there's an identical path through the code for all types that 
lets us compare the old value with the new value so we can signal back to 
the caller whether anything actually changed (at which point we have the 
raw string we want to stuff into the store anyway, so we might as well use
it)

Sliced and diced the history into smaller chunks, hopefully
this makes it much easier to review.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list