[Bug 29799] Add tests for TLS server channels

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Sep 14 19:55:55 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=29799

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|review-                     |review-, trivia

--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk> 2010-09-14 10:55:54 PDT ---
+        with open(CA_KEY, 'rb') as file:
+            pem_key = file.read()
+            file.close()
+            pkey = crypto.load_privatekey(crypto.FILETYPE_PEM, pem_key, "")

You don't need to call close(). That's one of the points of with: it's closed
when you leave that scope.

As we discussed on IRC, don't avoid UTF-8, just add coding=utf-8 to the top of
the comment.

http://git.collabora.co.uk/?p=user/cosimoc/telepathy-gabble.git;a=commitdiff;h=1fada095b5fb9215a75a5c3a5b18f604ee3abf5b
quite visibly shows a spaces vs. tabs mix-up towards the end of the diff.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list