[Bug 30201] Fix various build warnings in telepathy-mission-control

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30201

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-09-15 05:26:55 PDT ---
(In reply to comment #0)
> This patch fixes various obvious build warnings (by adding missing includes and
> other trivial fixes).

Thanks, your changes all look good. Fixed in git for 5.5.5, or for the 5.6.0
stable release if we decide we don't need another release-candidate.

> It's actually need to get a package in openSUSE for
> telepathy-mission-control 5.5.4...

If you're doing -Werror=format-security or something, with specific errors that
are unlikely to have false positives, then that's fair enough; if you're
building distro packages with -Werror, I really wouldn't advise that.

> There's still:
> account-store.c:198:3: warning: enumeration value 'OP_UNKNOWN' not handled in
> switch

I fixed that too, since non-release versions of MC build with -Werror. I'm not
sure how my build succeeded when I merged those patches in the first place :-(

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.