[Bug 30094] Have a convenience wrapper for wocky_porter_send_iq_async

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30094

--- Comment #3 from Eitan Isaacson <eitan.isaacson at collabora.co.uk> 2010-09-15 10:56:27 PDT ---
oops, I missed this review earlier.

(In reply to comment #2)
> > +  GError *error_ = NULL;
> 
> Call it wocky_error, please.

Got rid of this function.

> 
> > +conn_util_send_iq_finish_harder (GabbleConnection *self,
> 
> conn_util_send_iq_finish_with_tp_error? But I think I'd actually prefer a
> single finish function with two GError** parameters, one for the Wocky error
> and one for the Telepathized error (bonus points if you convert to TpError
> lazily).

The downside to that kind of finish function would be that you don't get the
mutually exclusive NULL pattern with error and res_pointer (you could get an
xmpp stanza, and also errors).

Not sure what you mean by a lazy conversion, should I be checking for (GError
**tp_error) != NULL before conversion? gabble_set_tp_error_from_wocky knows how
to deal with that (although it probably could return sooner, and not pass to
gabble_set_tp_conn_error_from_wocky if error == NULL).

Anyway, I added this in d1094e8. I hope the lazy "||" is not too hackish for
you!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.