[Bug 29378] Implement Channel.Interface.Messages

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29378

--- Comment #3 from Danielle Madeley <danielle.madeley at collabora.co.uk> 2010-09-16 02:46:46 PDT ---
Why have a NUM_SUPPORTED_MESSAGE_TYPES? G_N_ELEMENTS() seems more useful.

+ if (content_type == NULL || tp_strdiff (content_type, "text/plain"))

Why is @content_type == NULL special?

+    if (text == NULL)

Do you also need to check for strlen == 0?

+        goto despair_island;

Amusing, but I'm thinking no.

Could the message received callback be made common and part of idle-text.c ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.