[Bug 29378] Implement Channel.Interface.Messages

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29378

--- Comment #4 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-09-16 05:41:52 PDT ---
(In reply to comment #3)
> Why have a NUM_SUPPORTED_MESSAGE_TYPES? G_N_ELEMENTS() seems more useful.

fixed.

> + if (content_type == NULL || tp_strdiff (content_type, "text/plain"))
> 
> Why is @content_type == NULL special?

removed.

> +    if (text == NULL)
> 
> Do you also need to check for strlen == 0?

I use tp_str_empty() now.

> +        goto despair_island;
> 
> Amusing, but I'm thinking no.

That's from Gabble :p
I renamed it.

> Could the message received callback be made common and part of idle-text.c ?

Good idea. Done.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.