[Bug 30094] Have a convenience wrapper for wocky_porter_send_iq_async

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30094

--- Comment #6 from Eitan Isaacson <eitan.isaacson at collabora.co.uk> 2010-09-16 09:05:30 PDT ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > The downside to that kind of finish function would be that you don't get the
> > > mutually exclusive NULL pattern with error and res_pointer (you could get an
> > > xmpp stanza, and also errors).
> > 
> > Right, that was the idea with my original _finish_harder(): you don't have to
> > care about the stanza at all if it has type='error'.
> > 
> > Simon, if you're super-super keen to only have one finish function, I would be
> > in favour of making this function not return a stanza if an error was extracted
> > from it. The advantage of having another function was that you could still use
> > the _send() helper, even if you did want to do more interesting error handling.
> > 
> > How about for now we claim YAGNI, and make the single _finish() function return
> > a non-NULL WockyStanza if and only if the reply wasn't type='error', and have a
> > single GError ** parameter? Eitan, I think this would work for your code using
> > this function. We can revisit this later if we need to.
> > 
> 
> The only useful thing to me in this recent change has been changing the finish
> function to a boolean, so that receiving a WockyStanza is not mandatory. I
> think a typical use is sending an IQ and expecting an empty ack result. No need
> to get the stanza for that.

Pushed, 209fa2d

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.