[Bug 29298] review Conn.I.ClientTypes

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29298

Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|r-, minor changes           |

--- Comment #2 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2010-09-20 03:42:24 PDT ---
Sigh, I already replied to this once. Let's do it again!

(In reply to comment #1)
> Why not just make gabble_presence_pick_resource_by_caps() accept a NULL
> predicate?

OK done.

> Why can't the method and contact attribute implementations share code?

They can now!

> Do you mean ‘result’?

I do.

> This is perverse. Assign directly to type when it's defined?

OK

> You should update the comment.

Done.

> If you generate a GEnum for the GabbleClientType enum, you can use
> wocky_enum_from_nick() to remove all this code. Oh hmm, I guess it'd be
> GFlags... but something similar presumably applies. The next function which
> does the reverse is harder because the flags aren't mutually exclusive.
> Something similar should be possible... get the GFlagsClass and iterate its
> ->values array.

Yeah that's better. Remind me to file a glib bug to merge all these helper
functions for GFlags/GEnum.

Now, let's try that again...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.