[Bug 29298] review Conn.I.ClientTypes

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29298

--- Comment #4 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2010-09-21 08:36:16 PDT ---
(In reply to comment #3)
> +      if (g_ptr_array_index (types, 0) != NULL)
> 
> Is this secret code for (types->len > 0)? If not, could you explain why not?
> It's not obvious to me.

Ah yes, that is now wrong. See this for a clarification:

http://git.collabora.co.uk/?p=user/jonny/telepathy-gabble.git;a=commitdiff;h=10fd7b2e

> The Android special case is pretty annoying, but it seems like a reasonable
> compromise. We should also nag Google to do the right thing.

I'll email them now.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.