[Bug 30292] openssl backend does not handle fatal errors during async writes correctly

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30292

--- Comment #5 from Will Thompson <will.thompson at collabora.co.uk> 2010-09-22 02:18:19 PDT ---
While we're here:


+          gint ignore_warning;
+          gchar *pending = g_memdup (buffer + written, psize);
+
+          ignore_warning = BIO_reset (session->wbio);
+          ignore_warning = BIO_write (session->wbio, pending, psize);

Why is it okay to ignore the return value of BIO_reset and BIO_write here? I
think ignore_warning was added to squash a Coverity warning. It might be nice
to add a comment explaining why it's there and why it's kosher.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.