[Bug 29218] TpStreamTube - high level stream tube API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29218

--- Comment #21 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-09-23 06:34:15 PDT ---
(In reply to comment #16)
> I removed the offer_existing API because it's untested and I think it's wrong.
> Let's focus on the "simple" use cases for now.
> Once we are happy with the API, I'll re-think about an API for the "already
> existing socket" case and use my wormux tube branch to test it.

I think that sounds fair enough. Anything that needs to use an existing socket
is unlikely to integrate with Tubes very well, in practice - e.g. logs will say
"connection from 127.0.0.1:4242" rather than "connection from Guillaume".

> I also implemented the logic making use of the access_control_param arg of
> NewRemoteConnection to properly identify incoming connections. I have a
> question though. We can identify connections only when using the Credentials or
> Port access control. What should we do if those are not available? In that case
> we can't guaranteed that the TpContact we pass when firing the "incoming"
> signal is actually the one using the connection. Should we then pass NULL
> isntead as we can't safely guarantee that this TpContact is the right one?

Yes, I think so.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.