[Bug 30430] Make wocky_implement_finish_* macros safer

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Sep 28 18:33:08 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=30430

--- Comment #3 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2010-09-28 09:33:07 PDT ---
Created an attachment (id=39020)
 View: https://bugs.freedesktop.org/attachment.cgi?id=39020
 Review: https://bugs.freedesktop.org/review?bug=30430&attachment=39020

Fix wocky_implement_finish_*() macro

Fix wocky_implement_finish_*() macro

* Make the wocky_implement_*() macro safer by calling _is_valid() before
  trying to propagate errors.
* Fixed missing scope (G_STMT_START/G_STMT_END) and missing parenthesis
* Don't call copy_func if the result is NULL (enabling use of g_object_ref
  as copy_func).
* Added missing ; now required when those macro are called.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list