[Bug 28413] Gabble DTMF

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28413

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://git.collabora.co.uk/
                   |                            |?p=user/smcv/telepathy-gabb
                   |                            |le-smcv.git;a=shortlog;h=re
                   |                            |fs/heads/dtmf
             Status|NEW                         |ASSIGNED
  Status Whiteboard|review-, minor changes and  |
                   |missing a test              |
         AssignedTo|telepathy-bugs at lists.freede |simon.mcvittie at collabora.co
                   |sktop.org                   |.uk

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-09-30 08:47:50 PDT ---
I've picked this up and brought it up to date with current telepathy-spec. See
"URL" field for my branch.

Recent versions of telepathy-spec add a MultipleTones method, which can be used
to send a pre-composed string of DTMF, so I ended up writing a small class to
"play" DTMF strings. This should really be in telepathy-glib, for which I'll
clone a bug.

Things in my branch I'm unsure about:

• It might try to send DTMF before a stream is connected, which I won't work
• The timings in media-channel.c (stop StartTone tones after at most 10
seconds; send MultipleTones with 200ms tones and 100ms gaps between them) are
entirely arbitrary, and someone who knows more about telephony might be able to
suggest better numbers

(In reply to comment #4)
> For starters, git commit messages are normally formatted with a shortish (less
> than 60 characters) "subject", followed by a blank line, and then the body of
> the message.

I've re-worded the commit message slightly to fit the "subject"/"body" pattern,
I hope you don't mind!

> A smoke test would be nice.

Added.

> (Actually, in recent spec. versions the semantics of the DTMF interface changed
> slightly to say that DTMF events should be sent on all audio streams — see
> http://telepathy.freedesktop.org/spec/org.freedesktop.Telepathy.Channel.Interface.DTMF.html#org.freedesktop.Telepathy.Channel.Interface.DTMF.StartTone
> — so if you were feeling keen you could change the implementation to do that.)

I did indeed feel keen.

> These DEBUG messages aren't particularly helpful unless they say which stream
> and event they apply to

... which they now do.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.