[Bug 35619] Gets really confused if a nick conflict occurs when joining a GTalk MUC

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35619

--- Comment #6 from Will Thompson <will.thompson at collabora.co.uk> 2011-04-04 09:46:05 PDT ---
(In reply to comment #5)
> + # As far as Gabble's concerned, the two other participants joined
> + # immediately after we did.
> + handle, handle_, handle__, foobar_handle = conn.RequestHandles(
> + cs.HT_CONTACT, jids + ['%s/foobar_gmail.com' % room_jid])
> + q.expect('dbus-signal', signal='MembersChangedDetailed',
> + predicate=lambda e: e.args[0:4] == [[foobar_handle], [], [], []])
> + q.expect('dbus-signal', signal='MembersChangedDetailed',
> + predicate=lambda e: e.args[0:4] == [[handle], [], [], []])
> 
> This looks as if it could be racy. What if the MCD signals apear before
> RequestHandles returns?

It does look suspicious. But libdbus/dbus-python (I forget which) reorders
messages when making blocking calls, so it's actually safe.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.