[Bug 28707] Clarify how to use hold/mute with Call

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Apr 6 16:12:50 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=28707

--- Comment #19 from David Laban <david.laban at collabora.co.uk> 2011-04-06 07:12:50 PDT ---
This is still blocking on me talking with sjoerd about the states sub-branch...
Y'know what: I think I might just rebase states into its own branch...

Done (removed 3 commits from this branch) with one commit added to the end to
make it compile and an optional commit for re-ordering. (Note that "Add a Muted
CallMemberFlag." has always been wrong, and I don't think it compiled even
before the rebase).

It might actually be worth re-ordering, so that the flags are [ringing, held,
muted, conference_host] rather than [ringing, held, conference_host, muted].
What do you think? (see the last commit on alsuren/muted. I'll happily merge
with or without this change)


(In reply to comment #18)
> I think the Mute stuff can be simplifieda but because I don't think muting can
> fail.
> 
> Otherwise++
The extra states in Mute are not just in case mute can fail. It is also to
provide feedback in case muting the stream takes a non-zero amount of time. I'd
rather not risk having the UI say that the call is muted when it isn't (through
implementation bugs or otherwise).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list