[Bug 27459] implement a fast-path for Connection properties from spec 0.19.2

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27459

--- Comment #5 from Olli Salli <ollisal at gmail.com> 2011-04-11 09:48:19 PDT ---
(In reply to comment #4)
> http://git.collabora.co.uk/?p=user/oggis/telepathy-glib.git;a=commitdiff;h=f4514c86c30c2cfa5a18de84918af5c8079a96c6
> 
> Doesn't TpDBusPropertiesMixin crash (or at least critical) if getting the
> GObject property fails?
> 

No :>

> http://git.collabora.co.uk/?p=user/oggis/telepathy-glib.git;a=commitdiff;h=222bfe4ee068d08c633457906610299f4c2d8eba
> 
> I think I'd split the grabbing-things-from-properties block into its own
> function, so that you can just return FALSE; when things go awry; this gets rid
> of the goto and would make it easier to skim-read.

I did.

I also split out the bit of the code which adds the interfaces to the TpProxy
as tp_proxy_add_interfaces. One more bit of API which we'll have to add to 0.14
:P

> 
> Test-wise, I guess that the existing tests implicitly exercise the new code
> paths, and the tests where you've deliberately broken the properties test the
> fallback?

Yes.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.