[Bug 36058] Available presence seen for a bit when switching from dnd to away

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=36058

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> 2011-04-12 11:44:12 PDT ---
The thing that most concerns me about this branch is that I can't see any way
that our initial capabilities will necessarily be sent.

Interestingly, as far as I can tell, conn_presence_set_initial_presence_async()
does not actually set our initial presence on the Shared Status code path. Also
shared_status_setup_cb() calls get_existing_privacy_lists_async(), which makes
no sense at all: if we have Shared Status, we shouldn't be looking at privacy
lists………

OHHHHHH! That's how it works. privacy_lists_loaded_cb() (the callback for 
 get_existing_privacy_lists_async()) is called when receiving the privacy lists
from the Google server fails (as it inevitably will), and that function calls
toggle_presence_visibility_async(). And this works in the test suite because
BaseXmlStream (and hence SharedStatusStream) responds to privacy list queries
in the negative by default.

I don't suppose you fancy tidying that up so that Gabble doesn't check for
privacy list support if the server does indeed support shared status, and just
calls toggle_presence_visibility_async() directly from shared_status_setup_cb()
in the success path? And also fix the shared status test case to forbid privacy
list queries (and set handle_privacy_lists to False in SharedStatusStream)?

On presence/shared-status.py: test the correct behaviour with away and xa:

+    #e = q.expect('dbus-signal', signal='PresenceUpdate')
+    #print e.args
+    #return

O rly.

+                     "chat"       : ['Please talk with me!',
+                                     'Work is overrated, let\'s chat']}

I thought you said the 'chat' status stops working as a result of this branch;
but your test tests it.

The other patches look fine, modulo my concern above.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.