[Bug 36011] Add Chan.I.SMS.GetLength()

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Apr 13 20:16:24 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=36011

--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk> 2011-04-13 11:16:23 PDT ---
This looks reasonable. I think there should be a recommendation that clients
SHOULD not call this method after every keystroke (I assume Empathy would call
it at most once a second or something?).

In the NotImplemented error annotation, suggest that clients fall back to
estimating the number of chunks internally. (The N900's UI, for instance, used
an SMS library to determine this in-process.)

Oh! for Maybe types.

I reluctantly think that Content should be aa{sv}: Ring, at least, can send
vCards.

Proof-reading nit-picks:

+            This method allows the client, without any knowledge of the
+            encoding mechanism to provide length details to the user.</p>

I think you're either missing a comma, or you should move “to provide length
details to the user” in place of the comma.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list